Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isssue434 - typing #772

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Isssue434 - typing #772

wants to merge 5 commits into from

Conversation

jeffwright13
Copy link
Collaborator

Adds 'legacy-style' type annotations to file basereport.py. This is for backwards compatibility with older version of Python <= 3.8).

BeyondEvil
BeyondEvil reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add mypy for type checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeyondEvil BeyondEvil BeyondEvil left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffwright13 @BeyondEvil