Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: pysat deprecations #40

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

MAINT: pysat deprecations #40

wants to merge 9 commits into from

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Oct 4, 2023 •
edited

Description

Addresses #39

pysat 3.2.0 will drop support for 3 of the test instruments.

  • Keeps tests where behaviour is migrated
  • Deletes tests where data type (2d pandas) is no longer supported
  • Generalize the tests for when dimension lengths in the test instruments change

Also, set the RC install test to "workflow_dispatch', which appears to be an oversight from a previous pull.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

via pytest locally and at GA

Test Configuration:

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing mentioned this pull request Oct 4, 2023
Open
3 tasks
@jklenzing jklenzing linked an issue Oct 4, 2023 that may be closed by this pull request
MAINT: remove deprecated instruments from tests #39
Open
3 tasks
@jklenzing jklenzing mentioned this pull request Oct 4, 2023
Merged
17 tasks
@jklenzing jklenzing added this to the 0.2.1 Release milestone Oct 4, 2023
@jklenzing jklenzing marked this pull request as ready for review October 4, 2023 21:08
@jklenzing jklenzing removed the request for review from JonathonMSmith November 30, 2023 21:43
@jklenzing
Copy link
Member Author

Going to use this as the basis for RC testing

@jklenzing
Copy link
Member Author

Tests currently failing because pysat 3.1.0 does not have the new kwargs for compatibility. Suggest we leave this until after the 3.2.0 release and add a minimum limit.

Tests with the RC are here: https://github.com/pysat/pysatSeasons/actions/runs/7052829433

aburrell
aburrell reviewed Dec 1, 2023
View reviewed changes
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@jklenzing @aburrell
Update .github/workflows/docs.yml
d14d860 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@jklenzing jklenzing mentioned this pull request Feb 20, 2024
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburrell aburrell aburrell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.1 Release
Development

Successfully merging this pull request may close these issues.

MAINT: remove deprecated instruments from tests
2 participants
@jklenzing @aburrell