Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove deprecated instruments from tests #39

Open
3 tasks
jklenzing opened this issue Oct 4, 2023 · 0 comments · May be fixed by #40
Open
3 tasks

MAINT: remove deprecated instruments from tests #39

jklenzing opened this issue Oct 4, 2023 · 0 comments · May be fixed by #40
Milestone

Comments

@jklenzing
Copy link
Member

jklenzing commented Oct 4, 2023

Is your feature request related to a problem? Please describe.
pysat 3.2.0 will drop 3 instruments that are used in the tests here. They either represent redundancy or features that will no longer be supported.

Describe the solution you'd like

  • Drop tests for pysat_testing2d (no longer supported)
  • Replace pysat_testing_xarray with pysat_ndtesting
  • Replace pysat_testing_2dxarray with pysat_ndtesting

Describe alternatives you've considered
😴

Additional context
There may need to be some updates at pysat to make pysat_ndtesing a suitable replacement for pysat_testing_xarray needed to update tests so that profile size is not hard wired

@jklenzing jklenzing linked a pull request Oct 4, 2023 that will close this issue
10 tasks
@jklenzing jklenzing linked a pull request Oct 4, 2023 that will close this issue
10 tasks
@jklenzing jklenzing added this to the 0.2.1 Release milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant