Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/BUG: use unzip from pysatNASA for TIEGCM #132

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Oct 5, 2023

Description

Addresses #128

pysatNASA 0.0.6 will have the capability to unzip files that are downloaded. This utilizes that feature, fixing the bug where multiple data_path values are specified.

Fixes an unreleased bug, so changelog not updated.

Setting to draft, since it relies on unreleased code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

pytest

Test Configuration:

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing changed the title ENH: use unzip from pysatNASA for TIEGCM ENH/BUG: use unzip from pysatNASA for TIEGCM Oct 5, 2023
@jklenzing jklenzing added bug Something isn't working enhancement New feature or request labels Oct 5, 2023
@jklenzing jklenzing added this to the 0.2.0 milestone Oct 5, 2023
@jklenzing jklenzing mentioned this pull request Oct 5, 2023
10 tasks
@jklenzing jklenzing linked an issue Oct 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ICON TIEGCM file download and pysatNASA 0.0.5
1 participant