Clean warning update #129
Open
Clean warning update #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a general clean warning variable for the general clean method.
Added the `_clean_warn` test attribute to the existing model Instruments.
Added a description of the changes to the log.
Pandas changed their behaviour at some point, added a try/except loop to ensure the missing time selection works regardless of the available kwargs.
10 tasks
Removed extra whitespace.
|
@jklenzing there's a problem with the pysatNASA integration 😿 |
|
|
I think you just need to update the data_path usage |
Updated the minimum version of pysatNASA and changed the download behaviour.
Update the tests run, partially complying with new standards.
Remove the pandas version limit to support earlier versions of python.
|
Ok @jklenzing any idea why pysatNASA isn't importing in these test? 🦦 |
Cycle the supported python versions.
Fixed the commands that expected us to have a pyproject.toml file.
Making some hopeful changes.
Forgot to add the file suffixes.
Coverage dropped to zero, this might fix it.
jklenzing
reviewed
Jul 10, 2023
Update operational test version limits. Co-authored-by: Jeff Klenzing <19592220+jklenzing@users.noreply.github.com>
Added a debug line to see if pysatNASA is being installed correctly before trying the pysatModels unit tests.
…Models into clean_warning_update
Added another import to see if pysatNASA can eventually succeed.
See what and where python is.
|
I've managed to generate a different error locally in a python 3.7 virtual environment after downgrading to pip 21.3.1 (same as in the GA workflow) and attempting to install pysatNASA. I get an ImportError for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses pysat/pysat#1129 changes by adding the new test attribute to the existing model Instruments.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran unit tests locally with the new pysat updates.
Test Configuration:
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release