Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: longitude orbits not working correctly or consistently #1001

Open
aburrell opened this issue May 2, 2022 · 2 comments
Open

BUG: longitude orbits not working correctly or consistently #1001

aburrell opened this issue May 2, 2022 · 2 comments
Labels
Milestone

Comments

@aburrell
Copy link
Member

aburrell commented May 2, 2022

Describe the bug
Longitude breaks for orbits are not robust and frequently break with unexpected results.

To Reproduce
DMSP is a good example for this. The longitude key is 'glon'. This will break whether you use longitude in the +/- 180 range or 0-360 range.

orbit_debug_26Mar2014

Expected behavior
I expect one orbit to have the whole range of longitudes. Bonus: latitude breaks. Currently 'polar' will break with the hemisphere changes. This could be easily adapted to break the orbit at the northern or southern peak of an orbit.

Desktop (please complete the following information):

  • OS: OS X Big Sur
  • Version Python 3.8
  • Other details about your setup that could be relevant: develop branch of pysatMadrigal
@aburrell aburrell added the bug label May 2, 2022
@aburrell
Copy link
Member Author

aburrell commented May 2, 2022

Another idea could be to have the orbital period in the Instrument file and allow the user to use the satellite orbital period with a user-specified starting point.

@rstoneback
Copy link
Collaborator

The longitude orbit iterator currently only looks for negative gradients in longitude, aka it is expecting longitudes to go from 0 to 360, rather than from 360 down to 0. The code needs an option for the type and value of the gradient to trigger off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants