-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecation of _indices #69
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
Should we disable doctests for the |
inequality/_indices.py
Outdated
|
||
warnings.warn( | ||
"The module _indices is deprecated and will be removed on 2025-01-01.", | ||
DeprecationWarning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeprecationWarning assumes that we cut a release, then change it to FutureWarning and make another release with that, then enforce the deprecation. Shall we rather go straight for FutureWarning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, let's change to a FutureWarning
.
@sjsrey shall we pick this back up again to get CI green? |
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
Slight issue I see is that this warning is emitted by |
Looks like have a fresh exception being thrown by bleeding edge
|
We still need to address these failures, either by skipping or updating. |
@jGaboardi that is fixed by geopandas/geopandas#3288 |
xref #67