Fix segfault due to integer overflow in ratio_color indexing #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the x1000 ratio is large enough (in my case it was 671075384), you can get negative ratio_color index due to the overflow. This commit avoids potential overflows inside ratio_color() and also in all places where it is called. Previous fix (commit d52abd2) masked the issue instead of fixing it, and didn't address all cases.
tvasenin
changed the title
|
@pyroscope Could you pls review and merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the x1000 ratio is large enough (in my case it was 671075384),
you can get negative ratio_color index due to the overflow.
This commit avoids potential overflows inside ratio_color() and also
in all places where it is called.
Previous fix (d52abd2, PR #112)
masked the issue instead of fixing it, and didn't address all cases.