WIP: use python poetry for distribution #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Istvan91
commented
Jul 23, 2021
Istvan91
commented
- rewrite github workflows to use python poetry
- remove travis
- update pyproject and poetry.lock
- remove setup.py and requirements.txt
- rewrite github workflows to use python poetry - remove travis - update pyproject and poetry.lock - remove setup.py and requirements.txt
mweinelt
reviewed
Jul 12, 2022
| @@ -37,4 +37,6 @@ six = "^1.15.0" | |||
| netaddr = "^0.8" | |||
|
|
|||
| [tool.poetry.dev-dependencies] | |||
| nose = "^0.10.0b1" | |||
| nose = "^1.3" | |||
There was a problem hiding this comment.
Please kill nosetests with fire. It is native python2 code and used 2to3 in setuptools to work on Python3, which setuptools drop in 58.0.
The tests were updated to run using the unittest module. There is no hard dependency on nose anyway.
GIC-de
force-pushed
the
master
branch
2 times, most recently
from
f028133
to
5300091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.