Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils script fetch_devices.py to generate device_descriptors automatically #88

Open
wants to merge 3 commits into
base: pup2.1.1
Choose a base branch
from

Conversation

Mattwmaster58
Copy link
Member

@Mattwmaster58 Mattwmaster58 commented Apr 20, 2020

This script automatically generates an up-to-date version of device_descriptors.py. It's a basic CLI script that support two options, --url and --output-path, both have sensible defaults. It makes no attempt to format the output on it's own as deferring to something like black greatly reduces complexity (and when #82 lands you won't even have to give a second thought) I've added device_descriptors.py as generated by the script and formatted by black.

@Mattwmaster58 Mattwmaster58 changed the base branch from dev to pup2.1.1 April 20, 2020 19:20
@Mattwmaster58 Mattwmaster58 changed the title Add script to generate device_descriptors automatically Add utils script fetch_devices.py to generate device_descriptors automatically Apr 20, 2020
Copy link
Contributor

@Granitosaurus Granitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though we should probably document this somewhere. Maybe add a docstring at the top of the file explaining this script a bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants