Give Users Access To waitForChromeToClose() Call #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users specify a `--user-data-dir=<path>` browser argument, `Launcher.waitForChromeToClose()` is not called and this causes messages such as the following after the program has exited.
```
Future exception was never retrieved
future: <Future finished exception=NetworkError('Protocol error Target.sendMessageToTarget: Target closed.')>
pyppeteer.errors.NetworkError: Protocol error Target.sendMessageToTarget: Target closed.
```
This is also a problem on Windows as it causes the exit code from `sys.exit(<code>)` to be clobbered with code 120 under some conditions.
This option will expose `waitForBrowserToClose` option to the Launcher.
|
An alternative to this PR would be to change the code to always wait for browser to close. I have not done testing but I suspect that this may not impact performance. Related to #225 |
|
Question: Shouldn't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users specify a
--user-data-dir=<path>browser argument,Launcher.waitForChromeToClose()is not called and this causes messages such as the following after the program has exited likeFuture exception was never retrieved ...This option will expose
waitForBrowserToCloseoption to the Launcher.