#155 Initial arm support #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmullen
reviewed
Sep 11, 2021
pyppeteer/chromium_downloader.py
Outdated
| @@ -48,7 +50,9 @@ | |||
|
|
|||
| def current_platform() -> str: | |||
| """Get current platform name by short string.""" | |||
| if sys.platform.startswith('linux'): | |||
| if ("system='Linux" and "machine='armv") in str(platform.uname()): | |||
There was a problem hiding this comment.
Try typing
("system='Linux" and "machine='armv")Into your REPL and see what it evaluates to :)
|
I submitted a pull request to adamurban#1 that fixes the above issues. Had to change the default installation path to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at adding arm support. Expects chromium to be installed at
/usr/bin/chromium(Which a normal installation should be, eg fromsudo apt-get install chromiumon a raspberry pi running the Raspberry Pi OS).