Class page must be an inheritance of AsyncIOEventEmitter instead base EventEmitter class to use method page.on's callback in coroutine #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with pyee ver 8.x.x default class EventEmitter lost ability to run coroutines using asyncio.ensure_future
This functionality in pyee provided by special class - AsyncIOEventEmitter (see help(pyee.AsyncIOEventEmitter))
So code that uses asyncio.ensure_future would throw error with pyee version >=8.0.0
Latest pyppeteer (pyppeteer-0.2.5) code has dependencies pyee (>=8.1.0,<9.0.0)
How to reproduce problem:
pyee <8.0.0 works properly, response_worker will be called
pyee >= 8.0.0 gives warning, response_worker will not be called