WIP: 2.1.1 puppeteer parity #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Granitosaurus
added
enhancement
This was referenced Feb 26, 2020
|
|
This was
linked to
issues
Mar 9, 2020
This was referenced Mar 12, 2020
the last implementation didn't even make sense
I'm not sure why I skipped this in the first place but my best guess is that the test server implementation was faulty causing this test to fail and I thought it was the test's fault. Now that the test server is A-OK, this test is unskipped
this is why that one test before was skipped: the test prior used used a 204, but then the next test also used a 204, but you can't use the same response twice. this changes things so each response is generated as needed
This was referenced Nov 13, 2020
This comment has been minimized.
This comment has been minimized.
Expose more security related fields
…t_server_response Add kwargs for onetime test server response
This fixes any InvalidState exceptions that occurred when terminating with an unrelated error.
icemonster
reviewed
Apr 30, 2021
|
|
||
|
|
||
| def rewriteError(error: Exception) -> Union[None, Dict[str, Dict[str, str]]]: | ||
| msg = error.args[0] |
There was a problem hiding this comment.
Issue #119
We probably want to check if error.args has any elements, otherwise this throws an exception
There was a problem hiding this comment.
I agree! We're accepting PRs against this branch if you'd like to make the necessary changes
Do not try to set an exception on finished futures
|
Legit question: why is 2.1.1 the target version if puppeteer now is in version 10? |
|
When the project started, 2.1.1 was the current version. We're behind
…On Sat., Sep. 11, 2021, 10:07 a.m. Ivan Gonzalez, ***@***.***> wrote:
Legit question: why is 2.1.1 the target version if puppeteer now is in
version 10?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGI56LIZPVDDE42YFA45GETUBN5DZANCNFSM4KZE5GZA>
.
|
|
Could the page make it a little bit more clear what the status of this branch is vs "dev", and which one is recommended that people a) user as end users and b) send patches to? It seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is huge rework for catching up with puppeteer 2.1.1
For more see:
https://github.com/pyppeteer/pyppeteer2/projects/3