Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser.close() raises error message when userDataDir option is set #126

Open
wants to merge 1 commit into
base: pup2.1.1
Choose a base branch
from

Conversation

nahos
Copy link

@nahos nahos commented Jun 3, 2020

###** Overview**
When using the data dir option , pyppeteer crashes with the bwlow error:
pyppeteer.errors.NetworkError: Protocol error Browser.close: Target closed..

Root Cause of the issue

Browser.close command was executed twice when a user provides a data dir.

Copy link
Member

@Mattwmaster58 Mattwmaster58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I'm gonna leave this PR in limbo until I get a chance to take a look @ the launcher tests, I haven't looked at the code in a while and want to make sure I have a good understanding of it all before trying to make any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants