Fix Tcl inside a virtualenv on Windows (issue #93) #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #93 for details and alternative solutions. One suggestion was to bring code from Lib\lib-tk\FixTk.py into site.py, but leaving site.py alone and copying a minimally modified FixTk.py to the Lib directory when the virtualenv is created seems cleaner to me. The only changes to FixTk.py were to replace sys.prefix with sys.real_prefix at lines 49 and 52.
Fixing this is really important because it affects matplotlib.
All nosetests pass and matplotlib and Tkinter work on python 2.6 and 2.7. Issue #93 referred to Python 2.6 so this would close it. A quick test importing tkinter and calling tkinter._test() in a Python 3.4 virtualenv shows the problem is unresolved there, but it probably doesn't matter anyway since Python 3.3 and venv.
This was automatically migrated from #627 to reparent it to the
masterbranch. Please see original pull request for any previous discussion.Original Submitter: @citterio