Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really handle lib64 #757

Closed
wants to merge 1 commit into from
Closed

Really handle lib64 #757

wants to merge 1 commit into from

Conversation

opoplawski
Copy link

@opoplawski opoplawski commented May 15, 2015 •
edited by BrownTruck

Another attempt at this.

I believe this fixes #605, #530 #565 (which I believe are all duplicates).

Not sure about code style - I was trying to not break too much api if possible, but not sure how possible that is.

@opoplawski
Copy link
Author

Ping? I've found this essential to creating pyvenv rpms.

Ivoz
Ivoz reviewed Aug 23, 2015
View reviewed changes
virtualenv.py
@@ -1037,6 +1042,7 @@ def path_locations(home_dir):
bin_dir = join(home_dir, 'bin')
elif not is_win:
lib_dir = join(home_dir, 'lib', py_version)
lib64_dir = join(home_dir, 'lib64', py_version)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this common convention across all major nix distros? And/or OS X?

@Ivoz Ivoz force-pushed the develop branch 2 times, most recently from d33e617 to 1682ed6 Compare September 20, 2015 16:57
@vitalyisaev2
Copy link

Need this feature a lot

@BrownTruck
Copy link

Hello!

As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the master branch. However, this Pull Request was made against the develop branch so it will need to be resubmitted against master. Unfortunately, this pull request does not cleanly merge against the current master branch.

If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged.

If this pull request is still valid, please rebase it against master (or merge master into it) and resubmit it against the master branch, closing and referencing the original Pull Request.

If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:

Another attempt at this.

I believe this fixes #605, #530 #565 (which I believe are all duplicates).

Not sure about code style - I was trying to not break too much api if possible, but not sure how possible that is.

---

*This was migrated from pypa/virtualenv#757 to reparent it to the ``master`` branch. Please see original pull request for any previous discussion.*

@BrownTruck
Copy link

This Pull Request was closed because it cannot be automatically reparented to the master branch and it appears to have bit rotted.

Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto master or merged master into it.

@BrownTruck BrownTruck closed this May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@opoplawski @vitalyisaev2 @BrownTruck @Ivoz