Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporates virtualenv-pythonw-osx #54 #211

Closed
wants to merge 1 commit into from

Conversation

gregglind
Copy link

@gregglind gregglind commented Jan 1, 2012

TODO:

  • What is the general fix for this for non-Framework installs?

*  makes Framework bundle virtualenvs play nicer with
   OSX widgets
*  based on work at https://github.com/gldnspud/virtualenv-pythonw-osx
*  Needs code review (fragile, path based, uses tmpfiles)

TODO:

*  What is the general fix for this for non-Framework installs?
@carljm
Copy link

carljm commented Jan 4, 2012

I'll have to leave the real review and testing here to someone who has OS X. I'm a bit concerned about introducing a dependency on having a C compiler available; we've been trying to get rid of the dependency on Xcode for OS X, and this would further entrench it. Maybe it could be made optional with a flag to virtualenv?

The C file itself could be included as a base64 blob like other support files, but it's short enough I'm not sure that's really necessary.

@gregglind
Copy link
Author

Is than an alternate solution that doesn't require gccfor this? Could we provide a binary for this file (compiled) then use install_name_tool to rejigger it, just like I do in the fix for #168 ?

cc #54

@Ivoz Ivoz force-pushed the develop branch 2 times, most recently from d33e617 to 1682ed6 Compare September 20, 2015 16:57
@BrownTruck
Copy link

Hello!

As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the master branch. However, this Pull Request was made against the develop branch so it will need to be resubmitted against master. Unfortunately, this pull request does not cleanly merge against the current master branch.

If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged.

If this pull request is still valid, please rebase it against master (or merge master into it) and resubmit it against the master branch, closing and referencing the original Pull Request.

If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:

makes Framework bundle virtualenvs play nicer with
OSX widgets
 based on work at https://github.com/gldnspud/virtualenv-pythonw-osx

 Needs code review (fragile, path based, uses tmpfiles)


TODO:


 What is the general fix for this for non-Framework installs?

---

*This was migrated from pypa/virtualenv#211 to reparent it to the ``master`` branch. Please see original pull request for any previous discussion.*

@BrownTruck
Copy link

This Pull Request was closed because it cannot be automatically reparented to the master branch and it appears to have bit rotted.

Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto master or merged master into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants