Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of base executable not found #1515 #1522

Merged
merged 8 commits into from Jan 30, 2020
Merged

Better handling of base executable not found #1515 #1522

merged 8 commits into from Jan 30, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Jan 29, 2020 •
edited

Improve the base executable discovery mechanism:

  • print at debug level why we refuse some candidates,
  • when no candidates match exactly, instead of hard failing fallback to the closest match where the priority of matching attributes is python implementation, major version, minor version, architecture, patch version, release level and serial (this is to facilitate things to still work when the OS upgrade replace/upgrades the system python with a newer version than what the virtualenv host python was created with),
  • always resolve system_executable information during the interpreter discovery, and the discovered environment is the system interpreter instead of the venv/virtualenv (this happened before lazily the first time we accessed and caused reporting that the created virtual environment is of type of the virtualenv host python version, instead of the system pythons version - these two can differ if the OS upgraded the system python underneath and the virtualenv host was created via copy),

Resolves #1515.

@gaborbernat gaborbernat mentioned this pull request Jan 29, 2020
Closed
@gaborbernat gaborbernat changed the title Interpreter failed to be found More gracious handling of base executable not found (fallback to closest one available) Jan 29, 2020
@gaborbernat gaborbernat changed the title More gracious handling of base executable not found (fallback to closest one available) Better handling of base executable not found (fallback to closest one available) Jan 29, 2020
@gaborbernat
Interpreter failed to be found
f60de6b 
Add debug message why we refuse an interprter found within
find_exe_based_of.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
when trying to discover the host pythons executable fallback to close…
6f742e5 
…st matches instead of hard fail

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
fix typo
46805d9 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
use micro instead of patch inside the python specification too
4fde4cd 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
fix and add better test by calling the system executable property
770fe0e 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
target interpreter will be the resolved system, not what the user poi…
8cb3120 
…nts us to

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
fixes
40f36a8 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
fix overzelous replace
49781b9 
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat changed the title Better handling of base executable not found (fallback to closest one available) Better handling of base executable not found #1515 Jan 30, 2020
@gaborbernat gaborbernat merged commit 9d37eb3 into pypa:rewrite Jan 30, 2020
@gaborbernat gaborbernat deleted the 1515 branch January 30, 2020 18:53
@encukou encukou mentioned this pull request Aug 10, 2020
Closed
encukou added a commit to encukou/tox-current-env that referenced this pull request Aug 11, 2020
@encukou
tests: Use sys.exec_prefix, not sys.executable, to determine the Pyth…
2e513fe 
…on run

Virtualenv 20.0 follows symlinks when populating sys.executable,
so we can't use it. (AFAIUI it's done to better handle cases where the
system executable is changed after a virtualenv is created.)
See: pypa/virtualenv#1522

sys.exec_prefix still points to inside the virtualenv, so use that
in the tests to determine what's being run.
@encukou encukou mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaborbernat @asottile