New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CentOs and Fedora support #1500
Conversation
da07320
to
8b3132f
Compare
I am extreamly happy to see this ticket raised. I can provide help on achieving this as I had to do the same distro-testing with other python packages, for the same scope: to test that we don't break on these. If you want I can easily setup a 3rd party CI jobs that would run on CentOS or Fedora and validate various aspects. On the other end that same kind of testing is easily achievable with containers, which could be run by almost any CI. For example I do have a |
Instead of hard coding patterns and guessing let's ask the host python via the sysconfig. Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@ssbarnea thank you very much. I'll merge this PR, I've tested on Fedora 29 and CentOS 7 and for myself, the test suite passed with flying colours. Feel free to take the code out for a sping yourself and let me know if you run into any issues. There exists one slight discrepancy between what the builtin venv module does and what we do. The platform library folder ( CC @hroncok you might be interested in this. |
I can test this somehow on Fedora 31 if needed. 29 is out of support. But our patches are the same regarding lib64. Not creating the symbolic link is probably OK. cc @encukou @stratakis |
On CentOS 7, I only know about 2.7, 3.4 (in EPEL) and 3.6. On recent Fedoras, there should be anything from 2.6, 2.7, 3.4-3.9 and pypy2+3. |
Yeah on fedora I could get all those easily and the test suite passed 😎 |
Instead of hard coding patterns and guessing let's ask the host python via the sysconfig (for stdlib) and distutils install (for virtualenv elements - we target pip installable envs here).
Resolves #1332
TODO:
[ ] validate again with Fedora
[ ] validate again with CentOS
[ ] add test for --copies