Type-check on Python 3.12 #4352
Draft
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm gonna leave this one for later. I won't have a choice but to tackle it to merge setuptools stubs from typeshed, but it doesn't affect pkg_resources which I'm focusing on for now. |
|
Looks like I'll have to handle a handful of the typeshed-related TODOs first. Because |
This was referenced May 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Actually type-check targeting all Python versions in CI, including 3.12
I'd rather if it was possible for the CI to tell mypy which python version to target to override
python_versionconfig.Pull Request Checklist
newsfragments/. (not public-facing)(See documentation for details)