Simplify FileList._safe_path for PathLike support #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
force-pushed
the
debt/simpler-safe-path
branch
from
141b894
to
704ad89
Compare
jaraco
force-pushed
the
debt/simpler-safe-path
branch
from
704ad89
to
5759357
Compare
…llow for path to be `PathLike`.
jaraco
force-pushed
the
debt/simpler-safe-path
branch
from
5759357
to
7918b35
Compare
|
I wonder if anyone is still dependent on the support for bytes decoding. I guess we should either retain compatibility or declare the change as backward-incompatible. I'll do the latter; we can back out the change (restore support for bytes) if it turns out to cause any trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathLike.Summary of changes
Supports pypa/distutils#237.
Pull Request Checklist
newsfragments/.(See documentation for details)