Implement a simplified wheel builder (avoid undocumented pypa/wheel API) #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2023
Merged
abravalheri
force-pushed
the
dev/avoid_wheel_unstable_api
branch
from
79e5761
to
c9a8429
Compare
abravalheri
force-pushed
the
dev/simplified_wheelbuilder
branch
from
f4e4737
to
7f05c32
Compare
abravalheri
changed the title
abravalheri
force-pushed
the
dev/simplified_wheelbuilder
branch
from
3deabb7
to
8ad5407
Compare
abravalheri
force-pushed
the
dev/avoid_wheel_unstable_api
branch
from
c9a8429
to
1667b68
Compare
abravalheri
force-pushed
the
dev/avoid_wheel_unstable_api
branch
from
1667b68
to
c03fd73
Compare
abravalheri
force-pushed
the
dev/simplified_wheelbuilder
branch
from
8ad5407
to
539a05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
WheelBuilderclass that suits setuptools needs.This means that this class does not have to be generic and can be simplified.
This can be leveraged in the future when creating editable or regular wheels, while avoiding external and cyclic dependencies.
This is part of a series of PRs:
install_requiresandextra_requiresthat deviates from core metadata #3903PKG-INFO#3904pypa/wheelAPI indist_info#3905pypa/wheelAPI ineditable_wheel#3907bdist_wheelfrompypa/wheel#3908The motivation for this series of PRs is the following:
.egg-infoand.dist-infodirectories is intertwined and implicit(See Adopt bdist_wheel from wheel project #1386).
pypa/wheelAPI which is not stable yet and is very likely to change in the future.pypa/wheelmaintainers previously described that the long term vision is to transferbdist_wheeldirectly to
setuptools(See pypa/wheel#262, pypa/wheel#472, pypa/wheel#472).Pull Request Checklist
changelog.d/.(See documentation for details)