Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows CI for 3.8 and the outdated command that was refactored to remove pkg_resources. #6146

Merged
merged 4 commits into from
May 24, 2024
Merged

Fix windows CI for 3.8 and the outdated command that was refactored to remove pkg_resources. #6146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54f87df
try 7.1.0
matteius May 24, 2024
3d33354
try 7.1.0
matteius May 24, 2024
149caa9
Update news fragment
matteius May 24, 2024
a14ddad
Merge branch 'main' into fix-win38-CI
matteius May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion news/6139.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
``pipenv`` converts off ``pkg_resources`` API usages. This necessitated also vendoring in:
* latest ``pipdeptree==2.18.1`` which also converted off ``pkg_resources``
* ``importlib-metadata==6.5.1`` to continue supporting python 3.8 and 3.9
* ``importlib-metadata==7.1.0`` to continue supporting python 3.8 and 3.9
* ``packaging==24.0`` since the packaging we were utilizing in pip's _vendor was insufficient for this conversion.
2 changes: 1 addition & 1 deletion pipenv/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from pipenv.utils.indexes import prepare_pip_source_args
from pipenv.utils.processes import subprocess_run
from pipenv.utils.shell import temp_environ
from pipenv.vendor.importlib_metadata._py39compat import normalized_name
from pipenv.vendor.importlib_metadata.compat.py39 import normalized_name
from pipenv.vendor.pythonfinder.utils import is_in_path

if sys.version_info < (3, 10):
Expand Down