Convert off pkg resources #6139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
force-pushed
the
convert-off-pkg_resources
branch
from
5de1df4
to
184683c
Compare
…ribute-metadata/20947/10 I should remvoe this import.
… but can be forced with this env var.
… but can be forced with this env var.
matteius
force-pushed
the
convert-off-pkg_resources
branch
from
9c92bd1
to
82f6d3a
Compare
…env where zipp got installed
…ipp got installed
matteius
force-pushed
the
convert-off-pkg_resources
branch
from
cabcd9b
to
1b13cd7
Compare
…to patch importlib-metadata version that we vendor.
matteius
force-pushed
the
convert-off-pkg_resources
branch
from
172d281
to
b3ad3b2
Compare
oz123
reviewed
Apr 24, 2024
matteius
force-pushed
the
convert-off-pkg_resources
branch
from
ee54164
to
c4475fb
Compare
|
The usual failure of :
Interesting is that here it fails for all Python versions. |
|
Please do not merge this before #6134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
The fix
I worked between myself and with Claude 3 Opus to iterate on fixing these things related to pkg_resources. I was aware pipdeptree did the important work of converting off pkg_resources and I vendored it in as a starting point and began with the environment.py and worked from there.
Fixes #6097
Fixes #5475
Still TODO:
Fix the
pipenv graphcommands and re-submit the possible import patch there, but the whole integration changed and I am out of Opus 3 messages for the night.The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.