Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "ImportError: No module named weakref" in Python 2.7 #2962

Closed
wants to merge 4 commits into from

Conversation

greyli
Copy link
Contributor

@greyli greyli commented Oct 9, 2018

close #2961

@greyli greyli changed the title Fix import error in Python 2.7 Fix "ImportError: No module named weakref in Python 2.7 Oct 9, 2018
@greyli greyli changed the title Fix "ImportError: No module named weakref in Python 2.7 Fix "ImportError: No module named weakref" in Python 2.7 Oct 9, 2018
@Jamim
Copy link
Contributor

Jamim commented Oct 9, 2018

I think it's reasonable to squash the commits.

@immerrr
Copy link
Contributor

immerrr commented Oct 9, 2018

Could you please also add backports.shutil_get_terminal_size in the same manner to also fix #2950 ?

@greyli
Copy link
Contributor Author

greyli commented Oct 9, 2018

@Jamim Thanks for the notice, but I think I did something wrong with Git.

@greyli
Copy link
Contributor Author

greyli commented Oct 9, 2018

Close in favor of #2967.

@greyli greyli closed this Oct 9, 2018
@greyli greyli deleted the patch-2 branch October 9, 2018 14:17
@Jamim
Copy link
Contributor

Jamim commented Oct 9, 2018

@greyli I believe this article might be helpful:
Git Tools - Rewriting History

@immerrr
Copy link
Contributor

immerrr commented Oct 9, 2018

Recovering from a merge with interactive rebase could be painful though.

I would suggest creating a new branch locally (which Grey Li did) and push it to update patch-2 branch on github, roughly smth like git push --force-with-lease origin fix-import-error-on-py-2:patch-2

@techalchemy
Copy link
Member

Git captures all activity in the reflog by default so it should be recoverable just by the original hash. Ping me on slack if you have trouble

@greyli
Copy link
Contributor Author

greyli commented Oct 10, 2018

@Jamim @immerrr @techalchemy Thanks for the tips!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipenv install/graph fail with 2018.10.9: ImportError: No module named weakref
4 participants