Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipenv roadmap and contributor-maintainer processes #4130

Closed
lucidyan opened this issue Feb 13, 2020 · 17 comments
Closed

Improve pipenv roadmap and contributor-maintainer processes #4130

lucidyan opened this issue Feb 13, 2020 · 17 comments
Labels
Type: Maintenance 🚧 This issue pertains to maintenance of pipenv itself.

Comments

@lucidyan
Copy link

To begin with, I’ll explain: I respect the developers of Pipenv and am very glad that such tools are being developed.

But damn it: for more than a year, no releases, no answers, no roadmaps - nothing. Chat in slack is also empty. And this is with the officially recommended dependency management tool!

Okay, two months ago we received a response from the maintainer @techalchemy, he promised a rollout soon and hung a critical label on the release task:
#4058 (comment)
Hurrah?

Not so far. From July last year and to the present moment, he hasn’t done a single commit (correct me, if I'm wrong) in this repo.

And on the pulse, it generally seems that the project is dead. For comparison, look at the pulse of poetry

The last commit to the master was made in November 2019 and breaks the tests, but who cares!


Okay, I’ll write again that my goal is not to offend anyone. But at the moment we have the main tool of the language, which is not supported by the maintainer. Which, in turn, do not want to somehow share their plans or solve a problem.

It's time to face the truth, look into your issues: you have failed completely to support the most important project for the python community. Admit this officially, and not in a hidden issue, but on the main page and write about your solution.

As I see the solutions (from the softest to the most radical):

  • Write a clear roadmap, make it public domain and attract people to contributing
  • Choose a new Maintainer
  • Close the project and join forces with @sdispater
@hartwork
Copy link

355 issues and 32 pull requests seem a bit much for a one or two hobbyist main maintainers. Seems like pipenv needs funding to get somewhere again. I just contacted the Python Software Foundation by mail on this matter.

@lucidyan
Copy link
Author

@hartwork Please write here when you receive an answer from the PSF, thanks!

@hartwork
Copy link

@hartwork Please write here when you receive an answer from the PSF, thanks!

I got one reply now. While feel that it's not appropriate for me to quote that reply verbatim here, it seems fair to say that I was pointed to the PSF grants program and to work with the current maintainers of the project. That makes good sense to me.

Based on the Git history on master of last 12 months, I obtained this list of people:

# git log --since="1 year ago" master  | fgrep Author | sed -e 's,frostming,Frost Ming,' -e 's,frostming@tencent.com,mianghong@gmail.com,' -e 's, <.*>,,' | sort | uniq -c | sort -n -r | sed -e 's,Author: ,,' | head -n5
    305 Dan Ryan
     89 Frost Ming
     24 Tapasweni Pathak
     11 John Vandenberg
     10 Kenneth Reitz

I'll try contact these people now, putting you @lucidyan in CC.

@svermeulen
Copy link

Is there a way for people to donate to this project? I couldn't find a link in the docs

@Flimm
Copy link

Flimm commented Feb 24, 2020

#4058

@felix-ht
Copy link

felix-ht commented Mar 2, 2020

@hartwork any updates?

@hartwork
Copy link

hartwork commented Mar 2, 2020

@hartwork any updates?

I got a first short reply from @techalchemy on 2020-02-22, replied back to him on 2020-02-23 with questions, waiting for a reply since then. No replies from the other four people so far.

@lucidyan
Copy link
Author

lucidyan commented Mar 4, 2020

@techalchemy
@frostming
@tapaswenipathak
@jayvdb
@kennethreitz

Will you give us any comments on the status of the project?

@brainwane
Copy link
Contributor

I spoke with @techalchemy in IRC today and pipenv now has an update in #3369 (comment) .

@frostming frostming added the Type: Maintenance 🚧 This issue pertains to maintenance of pipenv itself. label Mar 5, 2020
@triage-new-issues triage-new-issues bot removed the triage label Mar 5, 2020
@brainwane brainwane changed the title pipenv maintenance fucked up Improve pipenv roadmap and contributor-maintainer processes Mar 25, 2020
@brainwane
Copy link
Contributor

Thanks to everyone who commented in this issue.

Pipenv is working toward a new release -- see #3369 for specific details. The goal is to get that out this month.

I helped @techalchemy write a new update email he's just posted on distutils-sig (mirrored on the pypa-dev list). Dan notes:

As some of you may already know, I recently changed jobs and am now working for Canonical where I have part of my time allocated to open source work in general (and pipenv in particular).

So: thanks, Canonical!

Dan's email also includes a few ways you can help, directly and indirectly, to expedite this release.


#3369 is where people can watch the progress towards the next pipenv release. I've retitled this issue to reflect the TODOs that do still need to happen even after this release:

  • Write a clear roadmap, make it public domain and attract people to contributing

And - where you wrote "Choose a new Maintainer" - I'd say:

  • Add new maintainers

@brainwane
Copy link
Contributor

As a step towards a clearer future roadmap: @frostming @uranusjr @techalchemy I see that this milestone was closed in mid-2018 but isn't quite finished. Should those issues go into a milestone for, say, a July release?

@uranusjr
Copy link
Member

Some of them would be doable, e.g. Activate PIPENV_VENV_IN_PROJECT with --local. But both the Pipfile override and lock file metadata issues seem to be very involved and too far from being implementable IMO.

@brainwane
Copy link
Contributor

Per Dan's announcement just now the project's going through some process, communication, & related changes. @techalchemy after you get through the next release, I think working with @frostming and @uranusjr on a roadmap would be a good way to organize what would go into the subsequent release.

brainwane added a commit to brainwane/pipenv that referenced this issue May 28, 2020
Towards issue pypa#4130.

Signed-off-by: Sumana Harihareswara <sh@changeset.nyc>
brainwane added a commit to brainwane/pipenv that referenced this issue May 28, 2020
Towards issue pypa#4130.

Signed-off-by: Sumana Harihareswara <sh@changeset.nyc>
@brainwane
Copy link
Contributor

Pipenv 2020.5.28 is now out!

This roadmap and contribution process issue is, as I understand it, where folks will talk about improving the release cadence in the future. @techalchemy @frostming and @uranusjr are in charge of this, but I think next steps are:

  1. Set up a milestone for the next release
  2. Assess existing resources (who is committing time & money to Pipenv?)
  3. Start a public roadmap
  4. Add new maintainers
  5. Make a first pass on triaging/responding to all outstanding issues and pull requests
  6. Polish new contributor instructions (such as improving manual testing instructions and moving them into the docs)
  7. Start attracting more people to contributing

and I believe this sequence will go faster or slower depending on what Pipenv finds out in Step 2 (how much money and time is available even to do this). Could take a month, could take a year. Personally, I have donated maybe 16 hours to helping shepherd the most recent release and making comments like this one, in case that is a useful data point. (I don't plan to donate more time to Pipenv this year.)

Is there a way for people to donate to this project? I couldn't find a link in the docs

I'll quote Dan's post to the Discourse forum:

If your company uses Pipenv, ask them to sponsor Python packaging via the PSF so there’s a stronger fund for packaging work.

@hugovk
Copy link
Contributor

hugovk commented May 28, 2020

Tidelift has an estimated $371.12/month available for the maintainers ("lifters").

https://tidelift.com/lifter/search/pypi/pipenv

@matteius
Copy link
Member

matteius commented Jul 5, 2022

I am closing this issue out as myself and @oz123 are the current maintainers of the last half year.

I do have a question for @hugovk -- I followed that link https://tidelift.com/lifter/search/pypi/pipenv and it says This project is a part of the Tidelift Subscription. Tidelift is already paying the maintainers of this package for [project maintenance] Do you know is there anyway to verify if payments are being made and to who for the pipenv mainteance?

@matteius matteius closed this as completed Jul 5, 2022
@hugovk
Copy link
Contributor

hugovk commented Jul 5, 2022

I suggest you contact Tidelift directly, they should be able to help out:

https://tidelift.com/lifter/contact-us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance 🚧 This issue pertains to maintenance of pipenv itself.
Projects
None yet
Development

No branches or pull requests

10 participants