Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pipenv with poetry #654

Closed
9 tasks done
katherine-black opened this issue Jan 28, 2021 · 12 comments
Closed
9 tasks done

Replace pipenv with poetry #654

katherine-black opened this issue Jan 28, 2021 · 12 comments
Assignees
Labels
tech-debt Technical debt

Comments

@katherine-black
Copy link
Contributor

In GitLab by @infinitewarp on Mar 3, 2020, 12:55

Summary

As a cloudigrade developer, I want to use environment build tools that are actively maintained so that I can take advantage of features, bug fixes, and security patches.

The Python developer community at large seems to have decided that Pipenv should not be used because its owners or core maintainers appear to have abandoned it. See:

A leading alternative tool that fits a similar niche to Pipenv is currently Poetry. See:

If we choose something other than Poetry, please update this issue's title and description with appropriate details.

Acceptance Criteria

  • Verify we no longer use Pipenv to install dependencies:
    • in cloudigrade
    • in houndigrade
    • in drf-insights-pagination
  • Verify another tool and process has replaced Pipenv
    • Verify Dockerfiles are using the new tool
    • Verify GitLab CI job definitions are using the new tool
    • Verify developer documentation is updated with notes to use the new tool
  • Verify that the chosen tool correctly builds and installs pycurl in various environments.

Assumptions and Questions

  • Before making code changes, take a few minutes to verify that Poetry really is our best alternative.
@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 9, 2020, 09:45

I recently went through a Pipenv-to-Poetry conversion on a personal project. For reference, here is the diff:

https://gitlab.com/infinitewarp/quips/-/compare/c364edc0ba59f996ad821ea829d01102ff07c66a...master

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:27

marked the task Verify that the chosen tool correctly builds and installs pycurl in various environments. as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:27

marked the task in cloudigrade as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:30

marked the task in houndigrade as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:44

marked the task in drf-insights-pagination as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:44

marked the task Verify we no longer use Pipenv to install dependencies: as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:44

marked the task Verify developer documentation is updated with notes to use the new tool as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:44

marked the task Verify GitLab CI job definitions are using the new tool as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:44

marked the task Verify Dockerfiles are using the new tool as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:44

marked the task Verify another tool and process has replaced Pipenv as completed

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:45

I pulled, rebuilt virtualenvs, and reran tox with their own new virtualenvs for all repos on my local system, and everything appears to be working as expected. Thanks!

@katherine-black
Copy link
Contributor Author

In GitLab by @infinitewarp on Mar 12, 2020, 16:45

closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical debt
Projects
None yet
Development

No branches or pull requests

2 participants