Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail early when install path is not writable #7828

Closed
wants to merge 8 commits into from
Closed

Fail early when install path is not writable #7828

wants to merge 8 commits into from

Commits on Jul 30, 2020

  1. Fail early when install path is not writable 

    At the same time install location compatibility is checked.
    @McSinyx
    McSinyx committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    3b70f49 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for user install decision 

    Functional tests for conflict install locations are removed in favor of
the unittest which handle more cases.
    @McSinyx
    McSinyx committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    f6dce7e View commit details
    Browse the repository at this point in the history

  3. Drop redundant explicit bool checks and clarify site.ENABLE_USER_SITE 

    Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
    @McSinyx @webknjaz
    McSinyx and webknjaz committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    57d1305 View commit details
    Browse the repository at this point in the history

  4. Move decide_user_install to a separate unit test 

    The use of the function is also emphasized.
    @McSinyx
    McSinyx committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    33eb545 View commit details
    Browse the repository at this point in the history

  5. Allow --root to be used with other install dest options 

    Effectively user-site also need write permission checking.
    @McSinyx
    McSinyx committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    a7cd38b View commit details
    Browse the repository at this point in the history

  6. Fix commands.install.site_packages_writable signature

    @McSinyx
    McSinyx committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    e5ddcc7 View commit details
    Browse the repository at this point in the history

  7. Blacken decide_user_install and clarify log output

    @pradyunsg @McSinyx
    pradyunsg authored and McSinyx committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    90a1357 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. Improve log/error messages esp. ones involve ENABLE_USER_SITE 

    This is to be squashed with the commit above
    @McSinyx
    McSinyx committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    d7472a8 View commit details
    Browse the repository at this point in the history