delete some dead code

[asottile]

dead code detected via dead

(noticed this issue while doing this -- worked around it with grep)

here's the summary of the removed things:

• hidden: last reference removed in 8447f39
• _copy_dist_from_dir: introduced in 4c405a0 but not referenced
• has_requirements: last reference removed in 893f0b0
• read_text_file: last reference removed in 52d87f2
• remove_auth_from_url: last reference removed in 78371cc planned to be used in a future PR
• (several progress bar types): introduced in 0552ffe but never referenced

The eventual "clean" command I reached was:

dead --exclude '^docs/'  | grep -v '/_vendor/' | grep -Ev '^(news|InstalledCSVRow|unregister|pretty_eta|download_speed|MaxLevelFilter|BetterRotatingFileHandler|ColorizedStreamHandler|deprecated|ReqFileLines|RequirementInfo|CheckResult|PackageSet|CandidateSortingKey|SecureOrigin|Kind|format_option_strings|format_heading|format_usage|format_description|format_epilog) '

most of the exclusions are type aliases (asottile/dead#5 not recognizing PEP 484 type comments)

[asottile]

(sorry for the random ping, noticed this hasn't gotten any attention in 7 days) -- @pradyunsg does this look ok?

[pradyunsg]

Sorry for the delay in responding -- I'll get to this post #6106. :)

[asottile]

Sounds good! good luck with the new release 🎉

[asottile]

@pradyunsg ping :D

[pradyunsg]

Heyo! We're not at 19.0.2 yet -- I'll get to this once that's out the door.

[asottile]

@pradyunsg 👋 <3

[cjerdonek]

FYI, I think @zooba is using the remove auth method in his keyring PR, so if so it would be good to keep that in to prevent churn and make it easier to track where the code originally came from.

(Edit: the PR number is #5952, and I confirmed it is being used there.)

[pradyunsg]

Thanks @cjerdonek!

That means all but that method should probably get cleaned up. :3

[asottile]

I've rebased, leaving that one commit out

[pradyunsg]

Thanks @asottile! (for this PR and also for writing and open sourcing some really cool tools) :D

[asottile]

No problem! 🎉

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.