Release 24.1.beta1 #12673
Merged
Release 24.1.beta1 #12673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
force-pushed
the
release/24.1.beta1
branch
from
4cf6dc3
to
a6ea169
Compare
|
I've modified the changelog entries, since they seemed a bit wonky to me. |
|
I think a change we need to make to our changelog management process is actually making sure that the changelog entries are actually reviewed and to ensure that they look good in the final render. |
pradyunsg
commented
May 6, 2024
pradyunsg
force-pushed
the
release/24.1.beta1
branch
from
a6ea169
to
1071978
Compare
|
Hah, I'm rusty. The changes made to the generated changelog vs final changelog are reviewable on https://gist.github.com/pradyunsg/1bb79e9246f406d15428ac20baec3cd9 |
|
sigh It seems |
|
A re-run fixed that and the failures are all network-related, so I'm gonna go ahead and say that this is fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #12613