Show install progress when using --progress-bar=raw
#12601
+52
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yes i installed mypy locally to test this, so it should finally pass ci
|
Currently need to install packages individually to get around this, this PR would make wrapping pip alot more efficient. |
uranusjr
reviewed
Mar 28, 2024
uranusjr
reviewed
Mar 28, 2024
uranusjr
reviewed
Mar 28, 2024
uranusjr
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #11508 / #12586 which adds machine-readable install progress outputs.
Right now, unless pip is uninstalling a package to upgrade it, pip does not output any progress information for the actual install process. This means that any GUI wrapping pip cannot accurately display the current progress of the install. For example, if I wanted to be able to display "installing opencv-python", I would have no idea when opencv-python is actually installing. The best I would be able to do would be to display an indeterminate progress spinner and maybe guess where the install progress is at based on the uninstalling messages.
So, this PR solves that issue by outputting the current install progress when the
--progress-barsetting is set to "raw". I did try to add a regular progress bar to this as well, but due to the extra logging it does sometimes (like during uninstalls), a regular progress bar is not a good fit for this specific feature. Besides, this is only useful for those who want to display extra information that they cannot currently get from pip's output (which is why someone would be using the "raw" option anyway).Example screenshot:
