New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI Tests on both MacOS Arm and x86 #12593
base: main
Are you sure you want to change the base?
Conversation
121064c
to
6b08efc
Compare
Well they pass, and complete faster than any of the other workers, so seems like there's little reason not to enable? Marking ready for review. |
.github/workflows/ci.yml
Outdated
os: [Ubuntu, MacOS] | ||
# Run on both x86 and Arm MacOS according to: | ||
# https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories | ||
os: [ubuntu-latest, macos-12, macos-14] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... macos-latest should already be running the jobs on M1, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is unexpected, they appear to have started a 12 week roll out of macos-latest
to be M1 shortly after my PR: https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/
I checked a recent job and pip is not yet affected by this and is still on macos-12 (https://github.com/pypa/pip/actions/runs/8601739554/job/23569705793):
Operating System
macOS
12.7.4
21H1123
It's interesting they did this because I found a lot of community feedback the new images break lots of workflows, but these seemed to mostly stem from limitations of the M1 chips so perhaps GitHub just wanted to finally bite the bullet.
I only found one issue with pip's tests on the M1 runner, SVN isn't installed by default. I will make a seperate PR for that now, but I will leave this PR open as to whether to explicitly support both x86 and ARM or whether to just support what GitHub provides as latest.
6b08efc
to
6c8a64f
Compare
Pip's macos-latest runner is now macos-14 causing pip CI to fail: https://github.com/pypa/pip/actions/runs/8825862850/job/24230722241 This PR supports continuing to test x86 and ARM, where as my alternative PR fixes pip CI just for ARM: #12617 |
9d59d97
to
70826ad
Compare
This failure is new:
I guess it's a flaky test? I have no way to try to reproduce. |
70826ad
to
a61325a
Compare
Yup, I forced CI to rerun and this time the test passed. |
a61325a
to
1bcc4f3
Compare
1bcc4f3
to
8abf028
Compare
8abf028
to
95c319e
Compare
It occured to me that pip tests currently only run on MacOS x86, which at this point could be considered problematic.
Checking the documentation (https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories) it appears that you must manually specify which version of MacOS you want to get the Arm version.
This probably could be done a little more elegantly but first I wanted to see if all tests would pass on Arm.