Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI Tests on both MacOS Arm and x86 #12593

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

notatallshaw
Copy link
Contributor

@notatallshaw notatallshaw commented Mar 24, 2024

It occured to me that pip tests currently only run on MacOS x86, which at this point could be considered problematic.

Checking the documentation (https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories) it appears that you must manually specify which version of MacOS you want to get the Arm version.

This probably could be done a little more elegantly but first I wanted to see if all tests would pass on Arm.

@notatallshaw notatallshaw marked this pull request as ready for review March 24, 2024 04:13
@notatallshaw
Copy link
Contributor Author

Well they pass, and complete faster than any of the other workers, so seems like there's little reason not to enable?

Marking ready for review.

Comment on lines 110 to 112
os: [Ubuntu, MacOS]
# Run on both x86 and Arm MacOS according to:
# https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
os: [ubuntu-latest, macos-12, macos-14]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... macos-latest should already be running the jobs on M1, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is unexpected, they appear to have started a 12 week roll out of macos-latest to be M1 shortly after my PR: https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/

I checked a recent job and pip is not yet affected by this and is still on macos-12 (https://github.com/pypa/pip/actions/runs/8601739554/job/23569705793):

Operating System
macOS
12.7.4
21H1123

It's interesting they did this because I found a lot of community feedback the new images break lots of workflows, but these seemed to mostly stem from limitations of the M1 chips so perhaps GitHub just wanted to finally bite the bullet.

I only found one issue with pip's tests on the M1 runner, SVN isn't installed by default. I will make a seperate PR for that now, but I will leave this PR open as to whether to explicitly support both x86 and ARM or whether to just support what GitHub provides as latest.

@pradyunsg pradyunsg added the S: awaiting response Waiting for a response/more information label Apr 7, 2024
@notatallshaw notatallshaw changed the title Run CI Tests on MacOS Arm Run CI Tests on both MacOS Arm and x86 Apr 9, 2024
@notatallshaw
Copy link
Contributor Author

Pip's macos-latest runner is now macos-14 causing pip CI to fail: https://github.com/pypa/pip/actions/runs/8825862850/job/24230722241

This PR supports continuing to test x86 and ARM, where as my alternative PR fixes pip CI just for ARM: #12617

@notatallshaw notatallshaw force-pushed the run-ci-tests-on-macos-arm branch 2 times, most recently from 9d59d97 to 70826ad Compare April 25, 2024 02:18
@notatallshaw
Copy link
Contributor Author

This failure is new:

FAILED tests/functional/test_install.py::test_vcs_url_urlquote_normalization - pip._internal.exceptions.InstallationSubprocessError: bzr checkout --lightweight --quiet http://bazaar.launchpad.net/%7Edjango-wikiapp/django-wikiapp/release-0.1 /private/var/folders/hv/qqnln7cj5cg0n48fcrlmbz4m0000gn/T/pytest-of-runner/pytest-1/popen-gw1/test_vcs_url_urlquote_normaliz0/cache/release-0.1 exited with 3

I guess it's a flaky test? I have no way to try to reproduce.

@notatallshaw
Copy link
Contributor Author

notatallshaw commented Apr 25, 2024

I guess it's a flaky test? I have no way to try to reproduce.

Yup, I forced CI to rerun and this time the test passed.

@notatallshaw notatallshaw force-pushed the run-ci-tests-on-macos-arm branch 2 times, most recently from a61325a to 1bcc4f3 Compare April 25, 2024 22:57
@notatallshaw notatallshaw mentioned this pull request Apr 28, 2024
@pradyunsg pradyunsg removed the S: awaiting response Waiting for a response/more information label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants