pip requires the "-e" option to install from a scheme that starts with "git+git@"

[Kentzo]

Looks like it's not recognized and passed further into pkg_resources:

Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/pip/basecommand.py", line 223, in main
    status = self.run(options, args)
  File "/usr/local/lib/python3.4/site-packages/pip/commands/install.py", line 270, in run
    wheel_cache
  File "/usr/local/lib/python3.4/site-packages/pip/basecommand.py", line 275, in populate_requirement_set
    wheel_cache=wheel_cache
  File "/usr/local/lib/python3.4/site-packages/pip/req/req_install.py", line 212, in from_line
    wheel_cache=wheel_cache, constraint=constraint)
  File "/usr/local/lib/python3.4/site-packages/pip/req/req_install.py", line 66, in __init__
    req = pkg_resources.Requirement.parse(req)
  File "/usr/local/lib/python3.4/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2980, in parse
    reqs = list(parse_requirements(s))
  File "/usr/local/lib/python3.4/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2924, in parse_requirements
    "version spec")
  File "/usr/local/lib/python3.4/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2889, in scan_list
    raise RequirementParseError(msg, line, "at", line[p:])
pip._vendor.pkg_resources.RequirementParseError: Expected version spec in git+git@github.com:My/repo.git@master#egg=repo at +git@github.com:My/repo.git@master#egg=repo

[ajk8]

+1

+1

[RonnyPfannschmidt]

isnt it ssh+git?

[RonnyPfannschmidt]

whops, the other way around

[dmytroleonenko]

+1

[averges]

+1

[xavfernandez]

Well the valid url: git+ssh://git@github.com/My/repo.git is accepted by both.

I'd be more in favor of dropping support of the unholy, pip-specific git+git@github.com:My/repo.git syntax.

[Ivoz]

@xavfernandez minus the git+ (which is the pip specific part to any VCS url), git@github.com:My/repo.git is git specific, not pip specific. git docs say it is scp-like / accepted by ssh.

[xavfernandez]

I understand that, I just find it strange we needed to invent our own url like syntax.

>>> urlparse('git+git@github.com:My/repo.git')
ParseResult(scheme='', netloc='', path='git+git@github.com:My/repo.git', params='', query='', fragment='')
>>> urlparse('git+ssh://git@github.com/My/repo.git')
ParseResult(scheme='git+ssh', netloc='git@github.com', path='/My/repo.git', params='', query='', fragment='')

cc @rbtcollins @dstufft whether this needs to be added to PEP508

(For the record, I'd be in favor of dropping it)

[rbtcollins]

git+git@github.com: is not a URL - its an ssh style host reference, not a URL/URI.. https://www.ietf.org/proceedings/59/I-D/draft-ietf-secsh-scp-sftp-ssh-uri-01.txt covers ssh uri's, though its only a draft, and http://www.iana.org/assignments/uri-schemes/prov/git covers git:// urls - dropping support for the host reference stuff from pip is entirely appropriate.

[pradyunsg]

@dstufft @pfmoore @xavfernandez @rbtcollins Thoughts on this?

I'm in favour of deprecating and then dropping support for git+git; printing a message saying use git+shh instead.