Skip to content

Commit

Permalink
Merge pull request #12620 from notatallshaw/run-python-3.13-ci-tests-
Browse files Browse the repository at this point in the history
  • Loading branch information
uranusjr committed Apr 30, 2024
2 parents 411b981 + 8c7dfb7 commit 9ef0fdf
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ jobs:
- "3.10"
- "3.11"
- "3.12"
- "3.13"

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -167,14 +168,16 @@ jobs:
# - "3.9"
# - "3.10"
# - "3.11"
- "3.12"
- "3.12" # Comment out when 3.13 is final
- "3.13"
group: [1, 2]

steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}
allow-prereleases: true

# We use C:\Temp (which is already available on the worker)
# as a temporary directory for all of the tests because the
Expand Down
1 change: 1 addition & 0 deletions news/12620.trivial.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Enable Python 3.13 CI tests
2 changes: 1 addition & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def should_update_common_wheels() -> bool:
# -----------------------------------------------------------------------------
# Development Commands
# -----------------------------------------------------------------------------
@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12", "pypy3"])
@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "pypy3"])
def test(session: nox.Session) -> None:
# Get the common wheels.
if should_update_common_wheels():
Expand Down
1 change: 1 addition & 0 deletions tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
cffi @ https://github.com/python-cffi/cffi/archive/refs/heads/main.zip; python_version > "3.12" # Temporary workaround for Python 3.13 until next CFFI release
cryptography
freezegun
installer
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ def test_falsey_path_none() -> None:
assert wc.cache_dir is None


def test_subdirectory_fragment() -> None:
def test_subdirectory_fragment(tmp_path: Path) -> None:
"""
Test the subdirectory URL fragment is part of the cache key.
"""
wc = WheelCache("/tmp/.foo/")
wc = WheelCache(os.fspath(tmp_path))
link1 = Link("git+https://g.c/o/r#subdirectory=d1")
link2 = Link("git+https://g.c/o/r#subdirectory=d2")
assert wc.get_path_for_link(link1) != wc.get_path_for_link(link2)
Expand Down

0 comments on commit 9ef0fdf

Please sign in to comment.