Skip to content

Commit

Permalink
Clarify warning messages
Browse files Browse the repository at this point in the history
Dependencies should be more precise than requirements;
  • Loading branch information
sbidoul committed Apr 28, 2024
1 parent 85747e4 commit 4902c58
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/pip/_internal/operations/check.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def create_package_set_from_installed() -> Tuple[PackageSet, bool]:
package_set[name] = PackageDetails(dist.version, dependencies)
except (OSError, ValueError) as e:
# Don't crash on unreadable or broken metadata.
logger.warning("Error parsing requirements for %s: %s", name, e)
logger.warning("Error parsing dependencies of %s: %s", name, e)
problems = True
return package_set, problems

Expand Down
2 changes: 1 addition & 1 deletion tests/functional/test_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def test_basic_check_broken_metadata(script: PipTestEnvironment) -> None:

result = script.pip("check", expect_error=True)

assert "Error parsing requirements" in result.stderr
assert "Error parsing dependencies of" in result.stderr
assert result.returncode == 1


Expand Down

0 comments on commit 4902c58

Please sign in to comment.