Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glossary.rst #1537

Merged
merged 4 commits into from
May 15, 2024
Merged

Update glossary.rst #1537

merged 4 commits into from
May 15, 2024

Conversation

Sam1320
Copy link
Contributor

@Sam1320 Sam1320 commented Apr 30, 2024

fix seeming typo and add link to the correct term


馃摎 Documentation preview 馃摎: https://python-packaging-user-guide--1537.org.readthedocs.build/en/1537/

fix seeming typo and add link to the correct term
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing is sub-optimal but it's correct: a build backend does indeed build an sdist or a wheel.

@Sam1320
Copy link
Contributor Author

Sam1320 commented May 2, 2024

The phrasing is sub-optimal but it's correct: a build backend does indeed build an sdist or a wheel.

Good point. What about the phrasing in the last commit? I feel it is less ambiguous this way. I also removed the reference to "wheel" for clarity and also because its already inside the "Built Distribution" description. @webknjaz

source/glossary.rst Outdated Show resolved Hide resolved
Sam1320 and others added 2 commits May 13, 2024 04:40
Co-authored-by: chrysle <96722107+chrysle@users.noreply.github.com>
Copy link
Contributor

@sinoroc sinoroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[I wrote the initial glossary entry. I recall struggling to find a phrasing I would be entirely happy with, but gave up and settled on this awkward phrasing.]

I guess, technically the step from sdist to wheel goes through unpacking the sdist into a source tree before this source tree to the build backend. I am not sure the build backends really do accept an sdist as input. So this new phrasing might be correct enough.

@webknjaz
Copy link
Member

I am not sure the build backends really do accept an sdist as input.

They don't. The frontends do the unpacking as a part of the ephemeral build environment provisioning and call the backends against that dir on disk. cibuildwheel does that, and build recently got this feature. Pip was the first frontend to implement this logic, I think.

@webknjaz webknjaz added this pull request to the merge queue May 15, 2024
Merged via the queue into pypa:main with commit 7ea90b3 May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants