-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glossary.rst #1537
Update glossary.rst #1537
Conversation
fix seeming typo and add link to the correct term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrasing is sub-optimal but it's correct: a build backend does indeed build an sdist or a wheel.
Good point. What about the phrasing in the last commit? I feel it is less ambiguous this way. I also removed the reference to "wheel" for clarity and also because its already inside the "Built Distribution" description. @webknjaz |
Co-authored-by: chrysle <96722107+chrysle@users.noreply.github.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[I wrote the initial glossary entry. I recall struggling to find a phrasing I would be entirely happy with, but gave up and settled on this awkward phrasing.]
I guess, technically the step from sdist to wheel goes through unpacking the sdist into a source tree before this source tree to the build backend. I am not sure the build backends really do accept an sdist as input. So this new phrasing might be correct enough.
They don't. The frontends do the unpacking as a part of the ephemeral build environment provisioning and call the backends against that dir on disk. cibuildwheel does that, and build recently got this feature. Pip was the first frontend to implement this logic, I think. |
fix seeming typo and add link to the correct term
馃摎 Documentation preview 馃摎: https://python-packaging-user-guide--1537.org.readthedocs.build/en/1537/