Add support for context formatting in builder dependencies. #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwardrop
force-pushed
the
add_context_formatting_for_builder_deps
branch
from
d116be8
to
ba95c39
Compare
|
@ofek Will get this tidied up and add some unit tests today. Thanks for your prompt review! |
matthewwardrop
force-pushed
the
add_context_formatting_for_builder_deps
branch
from
ba95c39
to
fc8a5a8
Compare
|
@ofek Should be good to go, including the new unit tests. |
|
@ofek Any updates here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1199
Hi @ofek !
Thanks for this great tool. I (like @oddfacade) want to be able to use local dependencies in my build configuration (for custom version schemes in setuptools_scm, which cannot directly import modules at the project root because they do not want to include the project root in the Python path during build; see my previous attempt to solve my problem in PR to that project). This is my stab at a quick PR to enable support in Hatch for inserting a local module into the build environment, but I understand there is some discussion in #1331 about scaling back support for this context formatting, so if this is no longer desired feel free to reject it.
I have not added any unit tests yet, but feel free to suggest where and how many tests you think are required (or to simply add them if you prefer).