Fix terminal.style.spinner
config value
#1471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terminal.styles.spinner
has no effect, which seems to be a typo:While this simple fix solves the problem, this can cause a runtime error later while trying to show a spinner. I thought this might be even worse, so I created a special case where we call
Spinner()
instead and catchKeyError
. To get the original error message we have to usee.args[0]
(just Python things). Theelse
branch was kept alive since it was probably created for later extensibility.