fix: swap default for macos-max-compat #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/maxcompat
branch
from
9468445
to
7d1d3c5
Compare
|
Please do the opposite of the introductory PR: https://github.com/pypa/hatch/pull/699/files Essentially remove from all of those tests you mentioned and then enable explicitly in the actual test |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/maxcompat
branch
from
6f30245
to
c3df388
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
ofek
approved these changes
May 23, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users cannot get macOS 12+ as a minimum with this forcing 10.16.
I'd like to make #1445 a followup, as users might need to target an older macOS than the one they are running (cibuildwheel always does this, for example).