Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #394

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bradcornford
Copy link

@bradcornford bradcornford commented Sep 18, 2020

Apprise - caronc/apprise#219 - eliminate Slack webhook token restrictions

Docker - docker/docker-py#2188 - Fixed a bug where credential stores weren't queried for relevant registry
credentials with certain variations of the config.json file.

Before:

ouroboros    | 2020-09-16 14:38:47 : INFO : ouroboros : Version: 1.4.3-master
ouroboros    | 2020-09-16 14:38:47 : WARNING : NotifySlack : An invalid Slack (second) Token (XXXXXX) was specified.
ouroboros    | 2020-09-16 14:38:47 : ERROR : Apprise : Could not load URL: ********XXXXX
ouroboros    | 2020-09-16 14:38:47 : ERROR : notifiers : Could not add notifier ********XXXXX

After:

ouroboros    | 2020-09-19 10:17:05 : INFO : dockerclient : netdata will be updated
ouroboros    | 2020-09-19 10:17:15 : INFO : asyncio : Notifying 1 service(s) asynchronous.
ouroboros    | 2020-09-19 10:17:22 : INFO : NotifySlack : Sent Slack notification.
ouroboros    | 2020-09-19 10:17:35 : INFO : dockerclient : netdata will be updated
ouroboros    | 2020-09-19 10:17:50 : INFO : dockerclient : heimdall will be updated
ouroboros    | 2020-09-19 10:17:58 : INFO : asyncio : Notifying 1 service(s) asynchronous.
ouroboros    | 2020-09-19 10:17:58 : INFO : NotifySlack : Sent Slack notification.
ouroboros    | 2020-09-19 10:35:49 : INFO : ouroboros : Version: 1.4.3-master
ouroboros    | 2020-09-19 10:35:49 : WARNING : NotifySlack : No user was specified; using "Ouroboros".
ouroboros    | 2020-09-19 10:35:50 : INFO : asyncio : Notifying 1 service(s) asynchronous.
ouroboros    | 2020-09-19 10:35:50 : INFO : NotifySlack : Sent Slack notification.
ouroboros    | 2020-09-20 10:36:12 : INFO : dockerclient : netdata will be updated
ouroboros    | 2020-09-20 10:36:16 : INFO : asyncio : Notifying 1 service(s) asynchronous.
ouroboros    | 2020-09-20 10:36:20 : INFO : NotifySlack : Sent Slack notification.
ouroboros    | 2020-09-20 10:38:27 : INFO : dockerclient : netdata will be updated
ouroboros    | 2020-09-20 10:38:51 : INFO : dockerclient : nginx will be updated
ouroboros    | 2020-09-20 10:39:05 : INFO : asyncio : Notifying 1 service(s) asynchronous.
ouroboros    | 2020-09-20 10:39:05 : INFO : NotifySlack : Sent Slack notification.
ouroboros    | 2020-09-21 10:36:18 : INFO : dockerclient : netdata will be updated
ouroboros    | 2020-09-21 10:36:21 : INFO : asyncio : Notifying 1 service(s) asynchronous.
ouroboros    | 2020-09-21 10:36:24 : INFO : NotifySlack : Sent Slack notification.
ouroboros    | 2020-09-21 10:37:23 : INFO : dockerclient : netdata will be updated
ouroboros    | 2020-09-21 10:37:43 : INFO : asyncio : Notifying 1 service(s) asynchronous.
ouroboros    | 2020-09-21 10:37:44 : INFO : NotifySlack : Sent Slack notification.

Copy link
Member

@dirtycajunrice dirtycajunrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradcornford We have dependabot already bumping versions when applicable. Can you please provide reasoning as to what these version bumps provide?

@bradcornford
Copy link
Author

bradcornford commented Sep 18, 2020

Sure, apprise is bumped to fix an issue I saw with slack notification tokens not being recognised. Docker was dumped as it wasn't parsing my tags properly from dockerhub. Inglux was bumped just for good measure. They were all bumped to the latest patch for the current minor version.

@dirtycajunrice
Copy link
Member

For continuity can you please add to the description:

Apprise/Docker - The link to the release with the fix, output of the prior observed state of logs for you, and output of the current observed state of logs for you after the version bump

If influxdb has not observed an issue, please revert that version bump as the influxdb library has a history of bugs and unintentionally introducing new conditions would be unforunate

@nemchik
Copy link
Contributor

nemchik commented Oct 7, 2020

I could be wrong, but maybe changing >= to == in requirements.txt would make dependabot PR the latest for all of those as they become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants