Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Clean up hooks and run_tests_inside_pyodide #123

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MAINT Clean up hooks and run_tests_inside_pyodide #123

wants to merge 3 commits into from

Conversation

hoodmane
Copy link
Member

This makes run_tests_inside_pyodide work via fixtures and removes the custom
get_browser setup. It also moves some logic from hook.py into decorator.py
and run_tests_inside_pyodide.

hoodmane and others added 3 commits November 17, 2023 12:54
@hoodmane
MAINT Clean up hooks and run_tests_inside_pyodide
82968db 
This makes run_tests_inside_pyodide work via fixtures and removes the custom
`get_browser` setup. It also moves some logic from `hook.py` into `decorator.py`
and `run_tests_inside_pyodide`
@hoodmane
More cleanup
6dd7b16
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0ea369c 
for more information, see https://pre-commit.ci
ryanking13
ryanking13 reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up! Codewise looks okay to me but the doctest test doesn't seem to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanking13 ryanking13 ryanking13 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoodmane @ryanking13