Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scipy: Use NPY_BLAS_LIBS and NPY_LAPACK_LIBS environment variables #3048

Merged
merged 2 commits into from Aug 31, 2022

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Aug 31, 2022

Use environment variables to tell numpy about BLAS and LAPACK. I also removed the global library loading, fingers crossed we might not need it anymore now. Edit: reverted changes to library loading.

@rth
Copy link
Member

rth commented Aug 31, 2022

The reason we were not doing it is that then CLAPACK would be an extra dependency of numpy, and so adding 1.2MB to download (+ increased load time). Currently,what we are doing is equivalent to statically linking a subset of netlib BLAS / LAPACK in numpy (since as far as I remember it has a lite BLAS version) which is not ideal, but in practice this way is more lightweight with comparable performance.

This might change though once we switch to a high-performant BLAS #227

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK never mind my previous comment, you are doing it for scipy which is totally fine.

I also removed the global library loading, fingers crossed we might not need it anymore now.

Looks like this is still necessary, otherwise LGTM.

@hoodmane hoodmane changed the title Use NPY_BLAS_LIBS and NPY_LAPACK_LIBS environment variables Scipy: Use NPY_BLAS_LIBS and NPY_LAPACK_LIBS environment variables Aug 31, 2022
@hoodmane hoodmane merged commit 0df5f79 into pyodide:main Aug 31, 2022
@hoodmane hoodmane deleted the scipy-blas-lapack branch August 31, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants