Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Model.load/dump #803

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remove Model.load/dump #803

wants to merge 6 commits into from

Conversation

ikonst
Copy link
Contributor

@ikonst ikonst commented Jun 28, 2020

I think I called my_model_instance.dumps() one time too many.

@ikonst ikonst marked this pull request as ready for review June 28, 2020 03:49
@garrettheel
Copy link
Member

Should we provide guidance for an alternative? ._get_json() is private, so folks would not be able to maintain this functionality particularly easily right now

@ikonst
Copy link
Contributor Author

ikonst commented Jun 29, 2020

I'll punt on this until we can offer an alternative to people who might've been using this functionality for testing or small-scale backups (hope no one is using this "toy backup" for anything serious).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants