Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transact error #736

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Transact error #736

wants to merge 7 commits into from

Conversation

hallie
Copy link
Contributor

@hallie hallie commented Dec 25, 2019

Trying to make it easier to understand which item(s) caused the transaction to be canceled. Current approach is to return list of tuples with format ({item}, 'reason'), but may make more sense to do

{
    'reason1': [{}, {}],
    'reason2': [{}]
}

or adding a failure_reason key to each item in the list

formerly this but i have no idea how to use github

@ikonst
Copy link
Contributor

ikonst commented Sep 4, 2020

Me and @jpr71 just stumbled on another reason for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants