Fixed filter_condition examples in the docs #1204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aareon
reviewed
Nov 15, 2023
| @@ -136,11 +136,18 @@ Now, suppose that you want to search the table for users with a last name | |||
| for user in UserModel.query('Smith', UserModel.first_name.startswith('J')): | |||
| print(user.first_name) | |||
|
|
|||
| You can combine query terms: | |||
| You can combine query terms in filter conditions using OR: | |||
There was a problem hiding this comment.
I would clarify by saying
You can combine query terms in filter conditions using logical operators (ex,
|,&,==, etc.)
There was a problem hiding this comment.
Thanks for the review.
I have given a separate example for & just below this one. Not sure how == would work here for combining queries 🤔
Let me know if there are other logical operators that are supported here. I'll either add them in-line or add a separate example if they make more sense that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current examples don't work with DynamoDB because they are using
emailin the range key condition.It also doesn't seem like we can combine query terms for range conditions so I changed the wording to specify this is about filter conditions.
No code changes made.