Progress bar for neural network training #2216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
sdrave
reviewed
Nov 2, 2023
There was a problem hiding this comment.
Before looking into details, we have to agree on
- Whether to use rich or another library for progress bars. That library needs to be added to pyMOR's core dependencies I guess.
- Whether to have an internal progress bar interface which wraps around the chosen library and that is used everywhere.
Further, have you checked what happens if the output is piped into a file, for instance via tee?
Edit: It also has to play nicely in a jupyter environment.
|
@HenKlei, maybe something to discuss at today's developer meeting? |
Yes, good idea. I will put it on the agenda. |
|
The progress bar is not interactive anymore when piped through tee.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a progress bar using rich for the neural network training.