Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How-to guides #2140

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

How-to guides #2140

wants to merge 4 commits into from

Conversation

pmli
Copy link
Member

@pmli pmli commented Aug 9, 2023

  • adds two how-to guides (about running demos and converting NumPy arrays to NumpyVectorArrays)
  • removes "running demos" section from Getting Started
  • reorders docs sections
  • renames "pyMOR Tutorials" to "Tutorials"

@pmli pmli added the pr:new-feature Introduces a new feature label Aug 9, 2023
@pmli pmli added this to the 2023.2 milestone Aug 9, 2023
@pmli pmli linked an issue Aug 9, 2023 that may be closed by this pull request
@HenKlei
Copy link
Member

HenKlei commented Aug 10, 2023

Is the rendered documentation available somewhere? It seems like it was not uploaded.

@pmli
Copy link
Member Author

pmli commented Aug 10, 2023

It seems like docs deployments started failing recently: https://github.com/pymor/docs/commits/main/

At least, it seems like it is possible to access it via ZIV GitLab: https://pymor.zivgitlabpages.uni-muenster.de/-/pymor/-/jobs/1798414/artifacts/docs/_build/html/index.html


In particular, note that {{VectorSpace}} subclasses
(in this case, {{NumpyVectorSpace}})
should be used to build {{VectorArrays}}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be helpful to also show how to convert back. Especially that you need to transpose.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it fits here or if would be better to have a general "How to convert a VectorArray to a NumPy array?" guide (which would mention that NumpyVectorArrays have an array attribute, and that in general there is the to_numpy method which need not be implemented).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before moving forward with this, I'd really like to further discuss if we want this. IMHO, there should be a 'working with VectorArrays' tutorial, which I intend to write at some point. If there is such an tutorial, do we want to duplicate the information here? The two concerns I have:

  1. Nobody wants to write documentation. Maintaining existing documentation even less. The 'technichal overview' is a good example how documentation can rot. So the amount of text should be kept at a minimum.
  2. I have seen several cases of documentation featuring different categories like (howto, getting started, examples, in-depth information, etc.), where I was really confused where to look to find a specific piece of information. As such, I would really like clearly defined entry points to the documentation. The separation between 'how to' and 'tutorial' seems to vague to me.

@HenKlei
Copy link
Member

HenKlei commented Aug 11, 2023

In general I am not sure if we need the "How-to guides" in the end. I am always a bit lost where to look for information when having the API documentation, tutorials, how-to guides and so on. If possible, I would be for reducing the number of different resources of information to a minimum.

In this specific case, the VectorArrays will hopefully be explained in more detail in a separate tutorial (I think @sdrave is planning to write such a tutorial) which should serve as the first reference. In particular since an additional how-to guide also has to be maintained and kept up to date.

Maybe it could be an option to mainly refer (in the how-to guides) to specific points in tutorials where one can find the detailed information without having to write another how-to guide.

@pmli
Copy link
Member Author

pmli commented Oct 9, 2023

I agree that it should be clear to documentation readers (and writers) what is the point of how-to guides. To be honest, I have difficulty understanding how the medical analogy from Diátaxis applies to pyMOR. The best thing I could come up with is for how-to guides to be similar to a checklist (like the release checklists). For pyMOR, this could be a checklist for implementing new Operators (what methods are necessary and if to_matrix/projection should be extended) or for implementing interfaces to external solvers. Maybe we can discuss this in the next community meeting.

@pmli pmli self-assigned this Nov 2, 2023
@sdrave sdrave removed this from the 2023.2 milestone Nov 28, 2023
@sdrave sdrave added this to the 2024.1 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature Introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding first how-to guides
4 participants