Google drive multi-user regex fix #4285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malkstar
commented
Apr 27, 2023
| @@ -18,7 +20,7 @@ | |||
| class GoogledriveCom(BaseDownloader): | |||
| __name__ = "GoogledriveCom" | |||
| __type__ = "downloader" | |||
| __version__ = "0.34" | |||
| __version__ = "0.35" | |||
| __status__ = "testing" | |||
|
|
|||
| __pattern__ = r"https?://(?:www\.)?(?:drive|docs)\.google\.com/(?:file/d/|uc\?.*id=)(?P<ID>[-\w]+)" | |||
There was a problem hiding this comment.
Suggested change
| __pattern__ = r"https?://(?:www\.)?(?:drive|docs)\.google\.com/(?:file/d/|uc\?.*id=)(?P<ID>[-\w]+)" | |
| __pattern__ = r"https?://(?:www\.)?(?:drive|docs)\.google\.com/(?:u/[0-9]/)?(?:file/)?(?:u/[0-9]/)?(?:d/|uc\?.*id=)(?P<ID>[-\w]+)" |
not sure how this was lost from the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Google drive links can sometimes contain a user indicator if you are logged into multiple accounts in the browser where the link is generated.
Is this related to a problem?
#4282
Additional references
I'm not sure if this an issue which needs fixing, as it can be worked around by the user. However, supporting the URLs is not a massive change to the regex.
Tested in regex101.com against the test links in the code.