Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main] Recognize ddl.to and turb.to Issue 3702 #3770

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

OzzieIsaacs
Copy link
Contributor

@OzzieIsaacs OzzieIsaacs commented Oct 11, 2020

Describe the changes

I applied my suggested change from issue #3702 to make XFilesharing last in the list to compare the regexes
I furthermore updated ddl and turbobit plugin

Is this related to a problem?

Issue #3702

Additional references

@pep8speaks
Copy link

pep8speaks commented Oct 11, 2020

Hello @OzzieIsaacs! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers!We recommend to use black to automatically correct these files.

Comment last updated at 2021-04-03 18:05:31 UTC

@GammaC0de
Copy link
Member

Please remove the changes to plugin_manager.py

In my opinion, the filename should not affect the plugin order.
Also, I intend to make Xfilesharing disabled by default

@OzzieIsaacs
Copy link
Contributor Author

Hello @GammaC0de, I'm not ready to give up yet. I agree with you the name is not the best solution to get the plugins ordered. So another proposal:
I've added a member __order__, it can have any number (integer would normally sufficient, I now used float to have the same regex as for the version parser).
This __order__ variable is added to the dict and used for sorting. The only plugin which needs the order member really set is the XFIleSharing plugin to move it to the end, everything else can stay at default (e.g. 0).

What about this (I already changed the PR accordingly)?

@vuolter
Copy link
Contributor

vuolter commented Nov 9, 2020

As I remember plugins with pattern ^unmatchable$ should already run at the end, if no one else is matched.
If this not happen now, there is a bug or maybe some code was accidentally removed during the migration to py3.

@OzzieIsaacs
Copy link
Contributor Author

@voulter: I checked it again, it's not working (not for the development branch and also not for stable, as reported in #3702).
I didn't 100% get what is going on. It's matching with the name of XFilesharing, but the pattern looks like the one from "MultiAccount" (at least in pyload_ng)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants